.github/workflows/e2e.yml (1)

32-37: Derive PLUGIN_ID from the manifest once and reuse it everywhere.

build/setup.mk:13-17 already resolves the plugin ID from plugin.json, but this workflow keeps separate copies in the job env, config payload, deploy step, and assertion. If the manifest ID changes, make dist will build the new bundle while the rest of this workflow still targets the old ID.

One way to keep a single source of truth

     env:
       MM_SITEURL: http://localhost:8065
       MM_ADMIN_USERNAME: admin
       MM_ADMIN_PASSWORD: Admin_1234!
-      PLUGIN_ID: com.mattermost.demo-plugin

+      - name: Resolve plugin ID
+        run: echo "PLUGIN_ID=$(./build/bin/manifest id)" >> "$GITHUB_ENV"
...
-          curl -sf -X PUT ${{ env.MM_SITEURL }}/api/v4/config/patch \
+          cat >/tmp/plugin-config.json <<EOF
+          {
+            "PluginSettings": {
+              "Plugins": {
+                "$PLUGIN_ID": {
+                  "username": "demouser",
+                  "channelname": "demo",
+                  "lastname": "User"
+                }
+              }
+            }
+          }
+          EOF
+          curl -sf -X PUT ${{ env.MM_SITEURL }}/api/v4/config/patch \
             -H "Authorization: Bearer $TOKEN" \
             -H 'Content-Type: application/json' \
-            -d '{
-              "PluginSettings": {
-                "Plugins": {
-                  "com.mattermost.demo-plugin": {
-                    "username": "demouser",
-                    "channelname": "demo",
-                    "lastname": "User"
-                  }
-                }
-              }
-            }'
+            --data `@/tmp/plugin-config.json`

Also applies to: 104-117, 126-126, 145-150

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/e2e.yml around lines 32 - 37, The workflow currently
hardcodes PLUGIN_ID in multiple places; change it to derive the ID once from
plugin.json and reuse that variable across the job (replace the env PLUGIN_ID,
the config payload, the deploy step, and the assertion). Read the plugin
manifest (plugin.json) at job runtime (similar to build/setup.mk's logic) and
export the derived value as a single PLUGIN_ID environment variable for the job,
then reference that environment variable everywhere instead of hardcoding the
ID.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes